Damienbod/2-2-TokenCache small improvements to readme and small code clean up #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmprieur Is the Greetings Damien |
jmprieur
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
LGTM. @damienbod
Do you have a strong feeling about the indentation in the startup.cs. The builder do a find of funnel.
| @@ -26,7 +26,7 @@ It leverages the ASP.NET Core OpenID Connect middleware and Microsoft Authentica | |||
|
|
|||
| To run this sample, you'll need: | |||
|
|
|||
| - [Visual Studio 2017](https://aka.ms/vsdownload) or just the [.NET Core SDK](https://www.microsoft.com/net/learn/get-started) | |||
| - [Visual Studio 2019](https://aka.ms/vsdownload) or just the [.NET Core SDK](https://www.microsoft.com/net/learn/get-started) | |||
There was a problem hiding this comment.
I wonder if we want to keep giving version :)
There was a problem hiding this comment.
no I don't think this makes sense, I'll remove it
| .EnableTokenAcquisitionToCallDownstreamApi(initialScopes) | ||
| .AddMicrosoftGraph(Configuration.GetSection("DownstreamApi")) | ||
| .AddDistributedTokenCaches(); | ||
| .AddMicrosoftIdentityWebApp(Configuration.GetSection("AzureAd")) |
There was a problem hiding this comment.
Actually the indentation is really based on the builders ...
jmprieur
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
2-2-TokenCache small improvements to readme and small code clean up
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?